linux-kernel - Re: [GIT PULL] x86/build change for v3.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5010547E.2090404@zytor.com>
Date:	Wed, 25 Jul 2012 13:18:06 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Sam Ravnborg <sam@...nborg.org>
CC:	Ingo Molnar <mingo@...nel.org>,
	"Kirill A. Shutemov" <kirill@...temov.name>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL] x86/build change for v3.6

On 07/25/2012 01:15 PM, Sam Ravnborg wrote:
>
> This is not as expected....
> In this silly example it is maybe obvious but I have lost hours tracking
> down bugs due to this.
> You add a new target and suddenly someting unrelated breaks.
>
> What happens is that make consider the assignment a command due to the leading
> tab - and because is follows a target (or other commands).
>
> I hope this makes it clear why many makefiles in the kernel uses tabs for indent.
>

This is also a good reason why not to indent assignments in Makefiles by 
full tab stops.  A smaller indent can't be scrambled this way.

	-hpa


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/