linux-kernel - Re: [PATCH] checkpatch: Update alignment check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1207260306590.30049@utopia.booyaka.com>
Date:	Thu, 26 Jul 2012 03:08:24 -0600 (MDT)
From:	Paul Walmsley <paul@...yaka.com>
To:	Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: Update alignment check

Hi Andy, Joe,

On Wed, 13 Jun 2012, Joe Perches wrote:

> Parenthesis alignment doesn't correctly check an existing line
> after an inserted or modified line with an open parenthesis.
> 
> Fix it.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Reviewed-by: Paul Walmsley <paul@...an.com>
Tested-by: Paul Walmsley <paul@...an.com>

This fixes some bogus checkpatch warnings here.  Andy, any chance this 
patch can make it in for 3.6-rc?

> ---
>  scripts/checkpatch.pl |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index e5bd60f..630319a 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1848,8 +1848,8 @@ sub process {
>  
>  			my $pos = pos_last_openparen($rest);
>  			if ($pos >= 0) {
> -				$line =~ /^\+([ \t]*)/;
> -				my $newindent = $1;
> +				$line =~ /^(\+| )([ \t]*)/;
> +				my $newindent = $2;
>  
>  				my $goodtabindent = $oldindent .
>  					"\t" x ($pos / 8) .
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/