| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Jul 2012 12:43:56 +0200 From: Paolo Bonzini <pbonzini@...hat.com> To: James Bottomley <James.Bottomley@...senPartnership.com> CC: Bart Van Assche <bvanassche@....org>, linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org Subject: Re: [PATCH 1/2] virtio-scsi: fix parsing of hotplug/hot-unplug LUN number Il 26/07/2012 12:33, James Bottomley ha scritto: >> > Has it already been considered to modify scsilun_to_int() such that LUN >> > numbers start at zero even for addressing method 1 ? This is what e.g. >> > the function scst_unpack_lun() already does. See also >> > http://scst.svn.sourceforge.net/viewvc/scst/trunk/scst/src/scst_lib.c?revision=HEAD&view=markup. > Yes, as I said before, the problem is that the actual numbers are > > 1. not 1:1: there are several possible encodings of luns 0-255 > 2. hierarchical, so once you go beyond a single level you can't properly > use a numeric representation either. > > the mid layer just uses the lun number as an encoding of the actual SAM > lun. The key for us is that int_to_scsilun has to go back the other > way. I still disagree, but I will modify QEMU so that this patch is not necessary. Later I can switch to int_to_scsilun. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists