linux-kernel - Re: [PATCH 16/21] ASoC: Ux500: Enable MOP500 driver for Device Tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120726113734.GZ3099@opensource.wolfsonmicro.com>
Date:	Thu, 26 Jul 2012 12:37:35 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	STEricsson_nomadik_linux@...t.st.com, linus.walleij@...ricsson.com,
	arnd@...db.de, sameo@...ux.intel.com, olalilja@...oo.se,
	ola.o.lilja@...ricsson.com, alsa-devel@...a-project.org, lrg@...com
Subject: Re: [PATCH 16/21] ASoC: Ux500: Enable MOP500 driver for Device Tree

On Thu, Jul 26, 2012 at 11:28:49AM +0100, Lee Jones wrote:

>  arch/arm/mach-ux500/board-mop500-msp.c |    3 ---
>  sound/soc/ux500/mop500.c               |   41 ++++++++++++++++++++++++++++++++

There is no binding documentation here.  All bindings should be
documented.

> -	pr_info("%s: Register platform-device 'snd-soc-u8500'.\n", __func__);
> -	platform_device_register(&snd_soc_mop500);
> -

This should be done separately - if it's going to be merged with
something it should be the patch that adds the relevant DT fragments.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)