linux-kernel - [RFC PATCH] KVM: Only print vcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120726122248.GA252@x4>
Date:	Thu, 26 Jul 2012 14:22:48 +0200
From:	Markus Trippelsdorf <markus@...ppelsdorf.de>
To:	kvm@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, Avi Kivity <avi@...hat.com>,
	Marcelo Tosatti <mtosatti@...hat.com>
Subject: [RFC PATCH] KVM: Only print vcpu_unimpl when DEBUG is set

Every time I start qemu-kvm on my system the following line is added to
the syslog:

 vcpu0 unhandled rdmsr: 0xc0010001

AFAICS all calls to vcpu_unimpl only contain debugging info with little
or no value for the end user.

Wouldn't something like the following patch make sense?

Signed-off-by: Markus Trippelsdorf <markus@...ppelsdorf.de>

diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index b70b48b..6bd816f 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -321,7 +321,7 @@ struct kvm {
 #define kvm_debug(fmt, ...) \
 	pr_debug("kvm [%i]: " fmt, task_pid_nr(current), ## __VA_ARGS__)
 #define kvm_pr_unimpl(fmt, ...) \
-	pr_err_ratelimited("kvm [%i]: " fmt, \
+	pr_debug_ratelimited("kvm [%i]: " fmt, \
 			   task_tgid_nr(current), ## __VA_ARGS__)
 
 /* The guest did something we don't support. */

-- 
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/