[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120726123017.GD25512@sepie.suse.cz>
Date: Thu, 26 Jul 2012 14:30:17 +0200
From: Michal Marek <mmarek@...e.cz>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
linux-kbuild <linux-kbuild@...r.kernel.org>
Subject: Re: kbuild: Document oldnoconfig to what it really does
On Fri, Jun 15, 2012 at 07:24:59PM -0400, Steven Rostedt wrote:
> The make target 'oldnoconfig' is a misnomer. It doesn't set new symbols
> to 'n', but instead sets it to their default values.
>
> Unfortunately, assuming that it actually did this, broke ktest in some
> of its tests. For example, the tests to create a minimum config and even
> a config bisect, depends on removing various configs and using
> oldnoconfig to get rid of other configs that may have depended on it.
>
> But because some configs that it was trying to disable, were in fact
> default enabled, this caused those configs to re-enable and corrupt the
> test.
>
> I thought about fixing oldnoconfig, but I'm afraid that people are
> already dependent on its current behavior. Instead, I'm just updating
> the documentation to state that it sets the new symbols to their default
> values and not to 'n'.
>
> Ideally, this would be called, 'olddefconfig' and we have an
> 'oldnoconfig' that actually disables the new symbols. But it's useless
> for me now. If it changed, ktest would need to be consistent between
> each version, and that would be to difficult to detect. I'll handle this
> issue with ktest with other means.
>
> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
Applied to kbuild.git#kconfig, thanks.
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists