linux-kernel - Re: [PATCH v3 6/7] scsi: sr: balance sr disk events block depth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120726124729.GB2022@localhost.localdomain>
Date:	Thu, 26 Jul 2012 20:47:32 +0800
From:	Aaron Lu <aaron.lu@....com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	James Bottomley <James.Bottomley@...senPartnership.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Jeff Garzik <jgarzik@...ox.com>, Lin Ming <minggr@...il.com>,
	Jeff Wu <jeff.wu@....com>, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-ide@...r.kernel.org, Aaron Lu <aaron.lwe@...il.com>
Subject: Re: [PATCH v3 6/7] scsi: sr: balance sr disk events block depth

On Thu, Jul 26, 2012 at 02:54:01PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 26-07-2012 14:05, Aaron Lu wrote:
> 
> >When the ODD is resumed, disk_unblock_events should be called when:
> >1 The ODD is runtime resumed;
> >2 System is resuming from S3 and the ODD is runtime suspended before S3;
> >But not when the system is resuming from S3 and the ODD is runtime
> >active before S3.
> 
> >So seperate the resume calls, one for system resume and one for runtime
> >resume to do different things accordingly.
> 
> >Signed-off-by: Aaron Lu <aaron.lu@....com>
> >---
> >  drivers/scsi/sr.c | 21 +++++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> 
> >diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c
> >index fd1c2f6..b8c2f9d 100644
> >--- a/drivers/scsi/sr.c
> >+++ b/drivers/scsi/sr.c
> [...]
> >@@ -211,6 +217,21 @@ static int sr_suspend(struct device *dev, pm_message_t msg)
> >
> >  static int sr_resume(struct device *dev)
> >  {
> >+	struct scsi_cd *cd = dev_get_drvdata(dev);
> >+
> >+	/*
> >+	 * If ODD is runtime suspended before system pm, unblock disk
> >+	 * events now since on system resume, we will fully resume it
> 
>    Comma not needed.

Thanks.

> 
> >+	 * and set its rumtime status to active.
> 
>    s/rumtime/runtime/. Nice typo. %-)

Thanks, and I'll use a spell checker next time to avoid such mistakes.

-Aaron
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/