linux-kernel - Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87pq7ioe4g.fsf@rustcorp.com.au>
Date:	Thu, 26 Jul 2012 22:47:51 +0930
From:	Rusty Russell <rusty@...abs.org>
To:	wei_wang@...lsil.com.cn, gregkh@...uxfoundation.org,
	devel@...uxdriverproject.org, linux-kernel@...r.kernel.org
Cc:	Wei WANG <wei_wang@...lsil.com.cn>
Subject: Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

On Fri, 20 Jul 2012 18:09:26 +0800, <wei_wang@...lsil.com.cn> wrote:
> +static int msi_en = 1;
> +module_param(msi_en, int, S_IRUGO | S_IWUSR);
> +MODULE_PARM_DESC(msi_en, "Enable MSI");

Should this be a bool, and a module_param(msi_en, bool, S_IRUGO | S_IWUSR);?

> +static int adma_mode = 1;
> +module_param(adma_mode, int, S_IRUGO | S_IWUSR);
> +MODULE_PARM_DESC(adma_mode, "ADMA Mode");

This too?

> +	/* Data transferred in ADMA mode or not */
> +	int			adma_mode;

And this?

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/