linux-kernel - Re: [PATCH 2/2] hw_random: add support for the TPM chip as a hardware RNG source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5011BD8C.4010301@zytor.com>
Date:	Thu, 26 Jul 2012 14:58:36 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Kent Yoder <key@...ux.vnet.ibm.com>
CC:	linux-kernel@...r.kernel.org, tpmdd-devel@...ts.sourceforge.net,
	m.selhorst@...rix.com, safford@...ibm.com,
	Jeff Garzik <jeff@...zik.org>
Subject: Re: [PATCH 2/2] hw_random: add support for the TPM chip as a hardware
 RNG source

On 06/07/2012 11:47 AM, Kent Yoder wrote:
> This driver will make use of any available TPM chip on the system as a
> hwrng source.
>
> Signed-off-by: Kent Yoder <key@...ux.vnet.ibm.com>
> ---
>   drivers/char/hw_random/Kconfig   |   13 +++++++++
>   drivers/char/hw_random/Makefile  |    1 +
>   drivers/char/hw_random/tpm-rng.c |   55 ++++++++++++++++++++++++++++++++++++++
>   3 files changed, 69 insertions(+), 0 deletions(-)
>   create mode 100644 drivers/char/hw_random/tpm-rng.c
>

So I just noticed this patch being pushed.

/dev/hw_random is used by rngd, which already has support for the TPM 
directly.  However, the TPM support in rngd conflict with tcsd (from 
TrouSerS).

Does this driver solve the coexistence problem?  If so, this is a Very 
Good Thing and should be accepted (and the TPM support in rngd 
deprecated/removed.)

If it does *not* solve the coexistence problem, then it just prevents a 
user space solution and the patch really should be rejected.

It would be great to get that clarified as soon as possible.

Thanks,

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/