linux-kernel - Re: [PATCH] ivtv: Declare MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Jul 2012 18:21:35 -0400
From:	Andy Walls <awalls@...metrocast.net>
To:	Tim Gardner <tim.gardner@...onical.com>
Cc:	linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	ivtv-devel@...vdriver.org, linux-media@...r.kernel.org
Subject: Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage

On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote:
> Cc: Andy Walls <awalls@...metrocast.net>
> Cc: Mauro Carvalho Chehab <mchehab@...radead.org>
> Cc: ivtv-devel@...vdriver.org
> Cc: linux-media@...r.kernel.org
> Signed-off-by: Tim Gardner <tim.gardner@...onical.com>
> ---
>  drivers/media/video/ivtv/ivtv-firmware.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c
> index 02c5ade..6ec7705 100644
> --- a/drivers/media/video/ivtv/ivtv-firmware.c
> +++ b/drivers/media/video/ivtv/ivtv-firmware.c
> @@ -396,3 +396,7 @@ int ivtv_firmware_check(struct ivtv *itv, char *where)
>  
>  	return res;
>  }
> +
> +MODULE_FIRMWARE(CX2341X_FIRM_ENC_FILENAME);
> +MODULE_FIRMWARE(CX2341X_FIRM_DEC_FILENAME);
> +MODULE_FIRMWARE(IVTV_DECODE_INIT_MPEG_FILENAME);

Only the PVR-350, based on the iTVC-15/CX23415 chip, needs the
CX2341X_FIRM_DEC_FILENAME and IVTV_DECODE_INIT_MPEG_FILENAME.  (And even
in the case of that card, not having the IVTV_DECODE_INIT_MPEG_FILENAME
file is non-fatal.)

I would not want anything in user-space or kernel space preventing the
ivtv module from loading, if some of those files don't exist.

Regards,
Andy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/