linux-kernel - Re: [PATCH 1/3] sysfs: introduce a sysfs_create_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120727155208.GB535@kroah.com>
Date:	Fri, 27 Jul 2012 08:52:08 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Bryan Wu <bryan.wu@...onical.com>
Cc:	ccross@...roid.com, hmh@....eng.br, rpurdie@...ys.net,
	linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH 1/3] sysfs: introduce a sysfs_create_file_uevent new API

On Fri, Jul 27, 2012 at 12:02:41PM +0800, Bryan Wu wrote:
> Send a uevent notification whenever a new sysfs file is created to allow
> userspace processes such as udev to modify permissions on the new files.

This makes no sense, why not just call kobject_uevent after creating the
file when needed?  Wrapping it up in a single function call doesn't add
any benefit that I can see, can you?

> 
> This new API function helps to do this.
> 
> Signed-off-by: Bryan Wu <bryan.wu@...onical.com>
> ---
>  fs/sysfs/file.c       | 28 ++++++++++++++++++++++++++++
>  include/linux/sysfs.h | 13 +++++++++++++
>  2 files changed, 41 insertions(+)
> 
> diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
> index 00012e3..5a22d13 100644
> --- a/fs/sysfs/file.c
> +++ b/fs/sysfs/file.c
> @@ -576,6 +576,34 @@ int sysfs_create_file(struct kobject * kobj, const struct attribute * attr)
>  
>  }
>  
> +/**
> + *	sysfs_create_file_uevent - create an attribute file for an object
> +					and send a uevent to userspace.

kerneldoc needs to be on one line for function names, right?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/