linux-kernel - Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120727180419.GA8262@dtor-ws.eng.vmware.com>
Date:	Fri, 27 Jul 2012 11:04:19 -0700
From:	Dmitry Torokhov <dtor@...are.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	"Andrew Stiegmann (stieg)" <astiegmann@...are.com>,
	pv-drivers@...are.com, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org, vm-crosstalk@...are.com
Subject: Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI
 build

Hi Alan,

On Fri, Jul 27, 2012 at 10:53:57AM +0100, Alan Cox wrote:
> > +enum {
> > +	VMCI_SUCCESS_QUEUEPAIR_ATTACH	=  5,
> > +	VMCI_SUCCESS_QUEUEPAIR_CREATE	=  4,
> > +	VMCI_SUCCESS_LAST_DETACH	=  3,
> > +	VMCI_SUCCESS_ACCESS_GRANTED	=  2,
> > +	VMCI_SUCCESS_ENTRY_DEAD	=  1,
> 
> We've got a nice collection of Linux error codes than you, and it would
> make the driver enormously more readable on the Linux side if as low
> level as possible it started using Linux error codes.

If VMCI was only used on Linux we'd definitely do that; however VMCI
core is shared among several operating systems (much like ACPI is) and
we'd like to limit divergencies between them while conforming to the
kernel coding style as much as possible.

We'll make sure that we will not leak VMCI-specific errors to the
standard kernel APIs.

Thanks,
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/