linux-kernel - Re: [PATCH 1/3] mfd: twl6040: Fix GPO mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaOmCe05NF2d5-1xqx7UmY80LTZXJG_Lj6rnFqyk_OvHg@mail.gmail.com>
Date:	Sat, 28 Jul 2012 00:45:24 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] mfd: twl6040: Fix GPO mask

On Wed, Jul 18, 2012 at 11:20 AM, Peter Ujfalusi <peter.ujfalusi@...com> wrote:

>  #define TWL6040_GPO1                   0x01
>  #define TWL6040_GPO2                   0x02
> -#define TWL6040_GPO3                   0x03
> +#define TWL6040_GPO3                   0x04

Maybe a stupid question but does these register defines really belong in that
header file? Can't you do a separate patch moving them into the driver per
se?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/