linux-kernel - Re: [PATCH] kernel/watchdog.c : fix smp_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVPdKzHXE=mV=FOx8xV4BLUEo_Ey9p6e9CkSOHxxYBfVgA@mail.gmail.com>
Date:	Fri, 27 Jul 2012 08:38:21 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	Don Zickus <dzickus@...hat.com>
Cc:	Sameer Nanda <snanda@...omium.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/watchdog.c : fix smp_processor_id() warning

On Fri, Jul 27, 2012 at 3:43 AM, Don Zickus <dzickus@...hat.com> wrote:
> On Wed, Jul 25, 2012 at 12:39:45PM +0800, Ming Lei wrote:
>> Use raw_smp_processor_id in lockup_detector_bootcpu_resume()
>> because it is enough when non-boot CPUs are offline.
>>
>> This patch fixes the following warning when DEBUG_PREEMPT
>> is enabled.
>
> Is this patched on top of linux-next?

Yes.

The warning is introduced by the commit below:

      7fb860ff90ae970cf62cf676dfc1addcf8415674
      (NMI watchdog: fix for lockup detector breakage on resume)


> It seems right based on the code usage.  Though it makes me sad the resume
> code has to hack into the cpu notifiers like that.

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/