linux-kernel - Re: [Xen-devel] [PATCH 06/24] xen: missing includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <501257F30200007800090D9E@nat28.tlf.novell.com>
Date:	Fri, 27 Jul 2012 07:57:23 +0100
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Stefano Stabellini" <stefano.stabellini@...citrix.com>,
	<linux-kernel@...r.kernel.org>
Cc:	<catalin.marinas@....com>, <arnd@...db.de>,
	<Ian.Campbell@...rix.com>, <linux-arm-kernel@...ts.infradead.org>,
	<linaro-dev@...ts.linaro.org>, <xen-devel@...ts.xensource.com>,
	<konrad.wilk@...cle.com>, <tim@....org>
Subject: Re: [Xen-devel] [PATCH 06/24] xen: missing includes

>>> On 26.07.12 at 17:33, Stefano Stabellini <stefano.stabellini@...citrix.com> wrote:
> --- a/include/xen/interface/xen.h
> +++ b/include/xen/interface/xen.h
> @@ -10,7 +10,10 @@
>  #define __XEN_PUBLIC_XEN_H__
>  
>  #include <asm/xen/interface.h>
> +#include <linux/types.h>
> +#ifdef CONFIG_X86
>  #include <asm/pvclock-abi.h>
> +#endif

Rather than hacking around this, why not clean it up:
asm/pvclock-abi.h clearly isn't intended to be included here
(from the perspective of the origin of xen/interface/xen.h, at
least), nor is linux/types.h.

Or if it is really needed to deviate from the original header in
this respect, then clearly the inclusion ought to not be arch
specific or be moved to an arch specific header.

Jan

>  
>  /*
>   * XEN "SYSTEM CALLS" (a.k.a. HYPERCALLS).


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/