linux-kernel - Re: [Xen-devel] [PATCH 17/24] xen: allow privcmd for HVM guests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5012598C0200007800090DB9@nat28.tlf.novell.com>
Date:	Fri, 27 Jul 2012 08:04:12 +0100
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Stefano Stabellini" <stefano.stabellini@...citrix.com>,
	<linux-kernel@...r.kernel.org>
Cc:	<catalin.marinas@....com>, <arnd@...db.de>,
	<Ian.Campbell@...rix.com>, <linux-arm-kernel@...ts.infradead.org>,
	<linaro-dev@...ts.linaro.org>, <xen-devel@...ts.xensource.com>,
	<konrad.wilk@...cle.com>, <tim@....org>
Subject: Re: [Xen-devel] [PATCH 17/24] xen: allow privcmd for HVM
 guests

>>> On 26.07.12 at 17:33, Stefano Stabellini <stefano.stabellini@...citrix.com> wrote:
> In order for privcmd mmap to work correctly, xen_remap_domain_mfn_range
> needs to be implemented for HVM guests.
> If it is not, mmap is going to fail later on.

Somehow, for me at least, this description doesn't connect to the
actual change.

> Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
> ---
>  drivers/xen/privcmd.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
> index ccee0f1..85226cb 100644
> --- a/drivers/xen/privcmd.c
> +++ b/drivers/xen/privcmd.c
> @@ -380,10 +380,6 @@ static struct vm_operations_struct privcmd_vm_ops = {
>  
>  static int privcmd_mmap(struct file *file, struct vm_area_struct *vma)
>  {
> -	/* Unsupported for auto-translate guests. */
> -	if (xen_feature(XENFEAT_auto_translated_physmap))
> -		return -ENOSYS;
> -

Is this safe on x86?

Jan

>  	/* DONTCOPY is essential for Xen because copy_page_range doesn't know
>  	 * how to recreate these mappings */
>  	vma->vm_flags |= VM_RESERVED | VM_IO | VM_DONTCOPY | VM_PFNMAP;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/