linux-kernel - drivers/mfd/tps65090.c: duplicated TPS65090_INT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120728123441.GB11202@localhost>
Date:	Sat, 28 Jul 2012 20:34:41 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	Venu Byravarasu <vbyravarasu@...dia.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Axel Lin <axel.lin@...il.com>, kernel-janitors@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: drivers/mfd/tps65090.c: duplicated TPS65090_INT_STS tests

Hi Venu,

Is this coccinelle warning a trivial one, or indicates some copy&paste
error? It's introduced by commit 3c33be06 ("mfd: Add support for
TPS65090").

drivers/mfd/tps65090.c:239:5-30: duplicated argument to && or ||

vim +239 drivers/mfd/tps65090.c
   236	
   237	static bool is_volatile_reg(struct device *dev, unsigned int reg)
   238	{
 > 239		if ((reg == TPS65090_INT_STS) || (reg == TPS65090_INT_STS))
   240			return true;
   241		else
   242			return false;

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@...ux.intel.com>                     Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/