linux-kernel - Re: [PATCH 2/3] regmap: implement irq chip suspend/resume operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120729210410.GM4384@opensource.wolfsonmicro.com>
Date:	Sun, 29 Jul 2012 22:04:10 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Stephen Warren <swarren@...dia.com>
Subject: Re: [PATCH 2/3] regmap: implement irq chip suspend/resume operations

On Fri, Jul 27, 2012 at 01:01:55PM -0600, Stephen Warren wrote:

> When suspending, we set up the wake mask registers as required. Some
> chips don't have separate wake mask registers, so they set mask_base
> equal to wake_base. In that case, when resuming, we re-program the

No, they shouldn't be doing that at all - that's at best confused.  The
two registers do different things and if the two ranges are set the same
then I'd not expect things to work.  Supporting that would make the code
more complex and I'm not sure what benefit we might gain from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/