linux-kernel - Re: [PATCH] gpio-sch: Fix leak of resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYqTNVpTF+NA34kCzKfuyD0aazv82GsyKFQt=mXeUR6vg@mail.gmail.com>
Date:	Sun, 29 Jul 2012 17:52:20 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Seth Heasley <seth.heasley@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio-sch: Fix leak of resource

On Tue, Jul 24, 2012 at 2:55 PM, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> From: Alan Cox <alan@...ux.intel.com>
>
> Signed-off-by: Alan Cox <alan@...ux.intel.com>
> ---
>
>  drivers/gpio/gpio-sch.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-sch.c b/drivers/gpio/gpio-sch.c
> index 424dce8..8707d45 100644
> --- a/drivers/gpio/gpio-sch.c
> +++ b/drivers/gpio/gpio-sch.c
> @@ -241,7 +241,8 @@ static int __devinit sch_gpio_probe(struct platform_device *pdev)
>                         break;
>
>                 default:
> -                       return -ENODEV;
> +                       err = -ENODEV;
> +                       goto err_sch_gpio_core;
>         }
>
>         sch_gpio_core.dev = &pdev->dev;

Applied to my fixes branch, CCing the list if there are complaints.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/