lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Jul 2012 18:00:59 +1000 From: Michael Ellerman <michael@...erman.id.au> To: Seth Jennings <sjenning@...ux.vnet.ibm.com> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>, Kent Yoder <key@...ux.vnet.ibm.com>, Herbert Xu <herbert@...dor.apana.org.au>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org, Paul Mackerras <paulus@...ba.org>, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, Andrew Morton <akpm@...ux-foundation.org>, Robert Jennings <rcj@...ux.vnet.ibm.com>, linuxppc-dev@...ts.ozlabs.org, "David S. Miller" <davem@...emloft.net>, linux-crypto@...r.kernel.org Subject: Re: [PATCH 3/4] powerpc/crypto: add 842 hardware compression driver On Fri, 2012-07-20 at 09:01 -0500, Seth Jennings wrote: > On 07/20/2012 12:33 AM, Michael Ellerman wrote: > > On Thu, 2012-07-19 at 09:42 -0500, Seth Jennings wrote: > >> This patch adds the driver for interacting with the 842 > >> compression accelerator on IBM Power7+ systems. > > > > ... > > > >> +struct nx842_slentry { > >> + unsigned long ptr; /* Absolute address (use virt_to_abs()) */ > >> /+ unsigned long len; > >> +}; > > > > These days virt_to_abs() is just __pa() - ie. convert to a real address. > > Thanks, I'll make that change. > > Is it a blocker to the code being pulled in though? I'm > hoping to get this in ASAP for the 3.6 merge window. As > this isn't a functional defect (I assume __pa() and > virt_to_abs() still achieve the same result), can I get an > OK from you that this isn't a blocker to the code being > accepted? Sorry I missed your reply. No it's not a blocker, just ugly. I have sent a series to Ben which removes virt_to_abs() entirely, so we'll want to make sure we fixup the nx driver before that goes in. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists