| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1343636024-20123-1-git-send-email-tracek@redhat.com> Date: Mon, 30 Jul 2012 10:13:44 +0200 From: Tomas Racek <tracek@...hat.com> To: linux-xfs@...r.kernel.org Cc: lczerner@...hat.com, Tomas Racek <tracek@...hat.com>, Ben Myers <bpm@....com> (supporter:XFS FILESYSTEM), Alex Elder <elder@...nel.org> (supporter:XFS FILESYSTEM), xfs@....sgi.com (supporter:XFS FILESYSTEM), linux-kernel@...r.kernel.org (open list) Subject: [PATCH 1/1] xfs: check for possible overflow in xfs_ioc_trim If range.start argument was between ULLONG_MAX - BBSIZE and ULLONG_MAX, BTOBB macro resulted in overflow which caused start to be set to 0. Now, invalid argument error is returned instead. Signed-off-by: Tomas Racek <tracek@...hat.com> --- fs/xfs/xfs_discard.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c index f9c3fe3..0ef7dd4 100644 --- a/fs/xfs/xfs_discard.c +++ b/fs/xfs/xfs_discard.c @@ -179,6 +179,10 @@ xfs_ioc_trim( * used by the fstrim application. In the end it really doesn't * matter as trimming blocks is an advisory interface. */ + + if (range.start > ULLONG_MAX - BBSIZE) + return -XFS_ERROR(EINVAL); + start = BTOBB(range.start); end = start + BTOBBT(range.len) - 1; minlen = BTOBB(max_t(u64, granularity, range.minlen)); -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists