linux-kernel - Re: [ 13/40] vmscan: shrinker->nr updates race and go wrong

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120730154130.GC28633@kroah.com>
Date:	Mon, 30 Jul 2012 08:41:30 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Mel Gorman <mgorman@...e.de>
Cc:	Ben Hutchings <ben@...adent.org.uk>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	Dave Chinner <dchinner@...hat.com>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [ 13/40] vmscan: shrinker->nr updates race and go wrong

On Mon, Jul 30, 2012 at 10:06:45AM +0100, Mel Gorman wrote:
> On Sun, Jul 29, 2012 at 09:29:30PM +0100, Ben Hutchings wrote:
> > > --- a/mm/vmscan.c
> > > +++ b/mm/vmscan.c
> > > @@ -251,17 +251,29 @@ unsigned long shrink_slab(struct shrink_
> > >  		unsigned long total_scan;
> > [...]
> > > +		total_scan += delta;
> > > +		if (total_scan < 0) {
> > [...]
> > 
> > This condition is never true since total_scan is unsigned.
> > I think 3.0.y needs this as well:
> > 
> > commit 635697c663f38106063d5659f0cf2e45afcd4bb5
> > Author: Konstantin Khlebnikov <khlebnikov@...nvz.org>
> > Date:   Thu Dec 8 14:33:51 2011 -0800
> > 
> >     vmscan: fix initial shrinker size handling
> > 
> 
> You're right, thanks for pointing it out as I missed it. Greg, this commit
> is already in 3.2 but can you pick it up for 3.0-stable please?
> 
> ---8<---
> vmscan: fix initial shrinker size handling
> 
> commit 635697c663f38106063d5659f0cf2e45afcd4bb5 upstream.

Now applied, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/