linux-kernel - Re: [PATCH RESEND] Ext4: No need to add inode to orphan list during hole punch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120730021927.GC21674@gmail.com>
Date:	Mon, 30 Jul 2012 10:19:27 +0800
From:	Zheng Liu <gnehzuil.liu@...il.com>
To:	Ashish Sangwan <ashishsangwan2@...il.com>
Cc:	Ted Tso <tytso@....edu>, linux-kernel@...r.kernel.org,
	linux-ext4@...r.kernel.org, lczerner@...hat.com,
	a.sangwan@...sung.com, namjae.jeon@...sung.com,
	Ashish Sangwan <ashish.sangwan2@...il.com>,
	Namjae Jeon <linkinjeon@...il.com>
Subject: Re: [PATCH RESEND] Ext4: No need to add inode to orphan list during
 hole punch

On Wed, Jul 25, 2012 at 07:53:34PM +0530, Ashish Sangwan wrote:
> While performing punch hole for an inode, i_disksize is not changed.
> So, there is no need to add the inode to orphan list.
> 
> Signed-off-by: Ashish Sangwan <ashish.sangwan2@...il.com>
> Signed-off-by: Namjae Jeon <linkinjeon@...il.com>

Acked-by: Zheng Liu <wenqing.lz@...bao.com>

Regards,
Zheng

> ---
>  fs/ext4/extents.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 91341ec..3e902f9 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -4801,9 +4801,6 @@ int ext4_ext_punch_hole(struct file *file, loff_t offset, loff_t length)
>  	if (IS_ERR(handle))
>  		return PTR_ERR(handle);
>  
> -	err = ext4_orphan_add(handle, inode);
> -	if (err)
> -		goto out;
>  
>  	/*
>  	 * Now we need to zero out the non-page-aligned data in the
> @@ -4889,7 +4886,6 @@ int ext4_ext_punch_hole(struct file *file, loff_t offset, loff_t length)
>  	up_write(&EXT4_I(inode)->i_data_sem);
>  
>  out:
> -	ext4_orphan_del(handle, inode);
>  	inode->i_mtime = inode->i_ctime = ext4_current_time(inode);
>  	ext4_mark_inode_dirty(handle, inode);
>  	ext4_journal_stop(handle);
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/