linux-kernel - Re: [RFC v2 2/2] net: Add support for NTB virtual ethernet device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120730181910.GB987@jonmason-lab>
Date:	Mon, 30 Jul 2012 11:19:11 -0700
From:	Jon Mason <jon.mason@...el.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-pci@...r.kernel.org, Dave Jiang <dave.jiang@...el.com>
Subject: Re: [RFC v2 2/2] net: Add support for NTB virtual ethernet device

On Mon, Jul 30, 2012 at 04:02:16PM +0200, Jiri Pirko wrote:
> Mon, Jul 30, 2012 at 02:26:34AM CEST, jon.mason@...el.com wrote:
> >+static int __devinit ntb_netdev_probe(struct pci_dev *pdev)
> >+{
> >+	struct net_device *ndev;
> >+	struct ntb_netdev *dev;
> >+	int rc;
> >+
> >+	ndev = alloc_etherdev(sizeof(struct ntb_netdev));
> >+	if (!ndev)
> >+		return -ENOMEM;
> >+
> >+	dev = netdev_priv(ndev);
> >+	dev->ndev = ndev;
> >+	dev->pdev = pdev;
> >+	BUG_ON(!dev->pdev);
> >+	ndev->features = NETIF_F_HIGHDMA;
> >+
> >+	//ndev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
> 	^^ I guess you forgot to un-comment this.

Oops.  An easy fix.  Anything else?

Thanks,
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/