linux-kernel - Re: [GIT PULL] New TPM driver, hwrng driver and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5016F429.9030800@zytor.com>
Date:	Mon, 30 Jul 2012 13:52:57 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Kent Yoder <key@...ux.vnet.ibm.com>
CC:	Kent Yoder <shpedoikal@...il.com>,
	James Morris <jmorris@...ei.org>, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	tpmdd-devel@...ts.sourceforge.net,
	Peter Huewe <peter.huewe@...ineon.com>,
	Bryan Freed <bfreed@...omium.org>,
	David Safford <safford@...ux.vnet.ibm.com>
Subject: Re: [GIT PULL] New TPM driver, hwrng driver and fixes

On 07/30/2012 01:51 PM, Kent Yoder wrote:
> 
>>> Perhaps we should just do the same "err = total ? total : -EIO;" here
>>> and the above statement can just turn into a break;.
>>
>>   Yeah, this seems like the right thing to do.
>>
>>>> -     ret = my_get_random(hash, SHA1_DIGEST_SIZE);
>>>> +     ret = tpm_get_random(TPM_ANY_NUM, hash, SHA1_DIGEST_SIZE);
>>>>       if (ret < 0)
>>>>               return ret;
>>>
>>> You are still not checking the return values correctly!
>>
>>   Dave, can you weigh in on these individual cases?  In some cases
>> like capping a pcr I think using uninitialized stack data could be
>> better than failing...
> 
> I got in touch with Dave today, who'd like the full checking done now
> that we can. Here's a new patch, let me know what you think...
> 
> Thanks,
> Kent
> 

Looks good to me.

Reviewed-by: H. Peter Anvin <hpa@...ux.intel.com>

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/