linux-kernel - Re: [PATCH 0/6] menuconfig: jump to search results

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 Jul 2012 09:57:51 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Benjamin Poirier <bpoirier@...e.de>
Cc:	Michal Marek <mmarek@...e.cz>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	Arnaud Lacombe <lacombar@...il.com>,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	Randy Dunlap <rdunlap@...otime.net>
Subject: Re: [PATCH 0/6] menuconfig: jump to search results

On Mon, Jul 30, 2012 at 04:22:12PM -0400, Benjamin Poirier wrote:
> It's against linux-next, which already contains some patches for
> menuconfig.

Ok, applying against the linux-next from today succeeds. And they seem
to work, I can search for CONFIG_* stuff and then go straight to the
results.

A couple more observations:

* The numbering in the search results looks kinda strange and
non-intuitive IMHO. Would it be possible to use the ncurses cursor to
iterate over the search results like one does in the normal menus? I.e.,
the horizontal bar which highlights the item with the background color
or whatever - can it be moved up and down with the arrow keys through
the search results too?

* when searching for "DELAY" for example, I get results without numbers
to which I can't jump to:

...
  │ Symbol: DEFAULT_IO_DELAY_TYPE [=0]
  │ Type  : integer
  │
  │
  │ Symbol: IO_DELAY_TYPE_0X80 [=0]
  │ Type  : integer
...

maybe because they don't have "---help---" section?

In those cases, you probably want to hide those from the search results?

Other than that it looks good and I'd say we need more menuconfig
functionality like that which eases/speeds up working with that thing :).

Thanks.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/