linux-kernel - Re: [PATCH] floppy: remove duplicated flag FD_RAW_NEED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1207311138430.30412@pobox.suse.cz>
Date:	Tue, 31 Jul 2012 11:39:02 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Fengguang Wu <fengguang.wu@...el.com>
Cc:	Joe Perches <joe@...ches.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] floppy: remove duplicated flag FD_RAW_NEED_DISK

On Sat, 28 Jul 2012, Fengguang Wu wrote:

> Fix coccinelle warning (without behavior change):
> 
> drivers/block/floppy.c:2518:32-48: duplicated argument to & or |
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
> 
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 553f43a..0fcbe14 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -2516,8 +2516,7 @@ static int make_raw_rw_request(void)
>  	set_fdc((long)current_req->rq_disk->private_data);
>  
>  	raw_cmd = &default_raw_cmd;
> -	raw_cmd->flags = FD_RAW_SPIN | FD_RAW_NEED_DISK | FD_RAW_NEED_DISK |
> -	    FD_RAW_NEED_SEEK;
> +	raw_cmd->flags = FD_RAW_SPIN | FD_RAW_NEED_DISK | FD_RAW_NEED_SEEK;
>  	raw_cmd->cmd_count = NR_RW;
>  	if (rq_data_dir(current_req) == READ) {
>  		raw_cmd->flags |= FD_RAW_READ;

Now that's a funny one. Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/