linux-kernel - Re: [RFC patch] vm: clear swap entry before copying pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJd=RBBe2XHwe7T+EKoomFq1t2Me+VbJkz92Ow15FjEsPLJUow@mail.gmail.com>
Date:	Tue, 31 Jul 2012 20:32:18 +0800
From:	Hillf Danton <dhillf@...il.com>
To:	Hugh Dickins <hughd@...gle.com>
Cc:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Mel Gorman <mgorman@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux-MM <linux-mm@...ck.org>
Subject: Re: [RFC patch] vm: clear swap entry before copying pte

Hi Hugh,

On Tue, Jul 31, 2012 at 10:34 AM, Hugh Dickins <hughd@...gle.com> wrote:
> But I can see that the lack of reinitialization of entry.val here
> does raise doubt and confusion.  A better tidyup would be to remove
> the initialization of swp_entry_t entry from its onstack declaration,
> and do it at the again label instead.


I just want to avoid allocating page in add_swap_count_continuation()
for non clear reason, as you see, which is not a bug fix.

Thanks,
		Hillf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/