linux-kernel - Re: [PATCH] staging:net:fixed to fit tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEAuANOHFYsDX-brey=83GvGWCwFJ9Lu_=8vsUu2a47bxaPN4g@mail.gmail.com>
Date:	Tue, 31 Jul 2012 20:54:51 +0800
From:	Baodong Chen <chenbdchenbd@...il.com>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	gregkh@...uxfoundation.org, jslaby@...e.cz, davem@...emloft.net,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging:net:fixed to fit tty_driver's kref field

On Mon, Jul 30, 2012 at 3:39 AM, Sam Ravnborg <sam@...nborg.org> wrote:
> On Sun, Jul 29, 2012 at 10:06:32PM +0800, Baodong Chen wrote:
>> Fixed code to fix tty_driver's kref field
>> Coding style issues
>>
>> Signed-off-by: Baodong Chen <chenbdchenbd@...il.com>
>
> Hi Baodong.
>
> As already pointed out by Jiri please split this
> up in several patches.
>
> [PATCH 1/x] staging:net:pc300: fix white space usage
> [PATCH 2/x] staging:net:pc300: add proper kref support
> [PATCH 3/x] staging:net:pc300: use pr_dev
> [PATCH 4/x] staging:net:pc300: drop use of CPC_TTY_LOCK/CPC_TTY_UNLOCK macros
> etc...
>
> The latter two is not impleted yet but proposals for further cleanups.
>
>         Sam
ok, i will follow that rule and resubmit it.
thanks!

>
>> ---
>>  drivers/staging/net/pc300_tty.c |  123 ++++++++++++++++++++------------------
>>  1 files changed, 65 insertions(+), 58 deletions(-)
>>
>> diff --git a/drivers/staging/net/pc300_tty.c b/drivers/staging/net/pc300_tty.c
>> index 4709f42..8a7277c 100644
>> --- a/drivers/staging/net/pc300_tty.c
>> +++ b/drivers/staging/net/pc300_tty.c
>
>>
>> -     cpc_tty = (st_cpc_tty_area *) tty->driver_data;
>> +     cpc_tty = (st_cpc_tty_area *) tty->driver_data;
>                                      ^drop space
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/