[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5017E29F.9010609@redhat.com>
Date: Tue, 31 Jul 2012 09:50:23 -0400
From: Don Dutile <ddutile@...hat.com>
To: Huang Ying <ying.huang@...el.com>
CC: Bjorn Helgaas <bhelgaas@...gle.com>, linux-kernel@...r.kernel.org,
linux-pci@...r.kernel.org, linux-pm@...r.kernel.org,
"Rafael J. Wysocki" <rjw@...k.pl>, Bjorn Mork <bjorn@...k.no>
Subject: Re: [RFC] PCI/PM: Add ABI document for sysfs file d3cold_allowed
On 07/30/2012 11:12 PM, Huang Ying wrote:
> Hi, Don,
>
> Thanks for your comments.
>
> On Mon, 2012-07-30 at 14:03 -0400, Don Dutile wrote:
>> On 07/27/2012 04:07 AM, Huang Ying wrote:
>>> This patch adds ABI document for the following sysfs file:
>>>
>>> /sys/bus/pci/devices/.../d3cold_allowed
>>>
>>> Signed-off-by: Huang Ying<ying.huang@...el.com>
>>> ---
>>> Documentation/ABI/testing/sysfs-bus-pci | 12 ++++++++++++
>>> 1 file changed, 12 insertions(+)
>>>
>>> --- a/Documentation/ABI/testing/sysfs-bus-pci
>>> +++ b/Documentation/ABI/testing/sysfs-bus-pci
>>> @@ -210,3 +210,15 @@ Users:
>>> firmware assigned instance number of the PCI
>>> device that can help in understanding the firmware
>>> intended order of the PCI device.
>>> +
>>> +What: /sys/bus/pci/devices/.../d3cold_allowed
>>> +Date: July 2012
>>> +Contact: Huang Ying<ying.huang@...el.com>
>>> +Description:
>>> + d3cold_allowed is bit to control whether the corresponding PCI
>>> + device can be put into D3Cold state. If it is cleared, the
>>> + device will never be put into D3Cold state. If it is set, the
>>> + device may be put into D3Cold state if other requirement are
>> did you mean 'requirements' here? -------------------------------^
>> or is there only 1 other requirement?
>
> I mean requirements here.
>
>>
>>> + satisfied too. Reading this attribute will show the current
>>> + value of d3cold_allowed bit. Writting this attribute will set
>> spell checker says 'Writing' --------------------^
>
> Sorry about my poor English and I should have spell checked it before
> sending out.
>
no problem! I figured since you were making the extra
effort to add the documentation, we might as well make it clear.
Thanks for the update.
> Best Regards,
> Huang Ying
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists