linux-kernel - Re: [PATCH] sysctl: fix improper indication of integer sysctl parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5498.1343743325@warthog.procyon.org.uk>
Date:	Tue, 31 Jul 2012 15:02:05 +0100
From:	David Howells <dhowells@...hat.com>
To:	Mitsuo Hayasaka <mitsuo.hayasaka.hu@...achi.com>
Cc:	dhowells@...hat.com, "Eric W. Biederman" <ebiederm@...ssion.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	James Morris <james.l.morris@...cle.com>,
	linux-kernel@...r.kernel.org, yrl.pp-manager.tt@...achi.com
Subject: Re: [PATCH] sysctl: fix improper indication of integer sysctl parameter

Mitsuo Hayasaka <mitsuo.hayasaka.hu@...achi.com> wrote:

> When we read the sysctl parameter, they are always treated
> as signed integer, and are casted into unsigned long type
> in the current kernel. If we set a value equivalent to
> (the maximum value in signed integer + 1)

Wouldn't it be better to return EINVAL or EDOM?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/