lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 31 Jul 2012 18:18:08 +0200 From: Damien Cassou <damien.cassou@...il.com> To: Mike Frysinger <vapier@...too.org> Cc: Florian Tobias Schandinat <FlorianSchandinat@....de>, kernel-janitors@...r.kernel.org, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/5] drivers/video/bfin-t350mcqb-fb.c: use devm_ functions On Tue, Jul 31, 2012 at 3:57 PM, Mike Frysinger <vapier@...too.org> wrote: > On Tue, Jul 31, 2012 at 9:54 AM, Damien Cassou <damien.cassou@...l.fr> wrote: >> The various devm_ functions allocate memory that is released when a driver >> detaches. This patch uses these functions for data that is allocated in >> the probe function of a platform device and is only freed in the remove >> function. > > Acked-by: Mike Frysinger <vapier@...too.org> This whole patch is invalid, because of this part: - info->fb_buffer = dma_alloc_coherent(NULL, fbinfo->fix.smem_len + - ACTIVE_VIDEO_MEM_OFFSET, - &info->dma_handle, GFP_KERNEL); + info->fb_buffer = dmam_alloc_coherent(&pdev->dev, NULL, + fbinfo->fix.smem_len + + ACTIVE_VIDEO_MEM_OFFSET, + &info->dma_handle, GFP_KERNEL); dmam_alloc_coherent() is called with 5 arguments but only accepts 4. Please ignore this whole patch altogether. I am sorry about that. -- Damien Cassou http://damiencassou.seasidehosting.st "Lambdas are relegated to relative obscurity until Java makes them popular by not having them." James Iry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists