linux-kernel - Re: [PATCH] samples/seccomp: fix endianness bug in LO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+PAk4xbcr=3=O4qBD=+1++i1DeE=TX5S9vT3UivcR72w@mail.gmail.com>
Date:	Tue, 31 Jul 2012 09:21:05 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Will Drewry <wad@...omium.org>,
	James Morris <james.l.morris@...cle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] samples/seccomp: fix endianness bug in LO_ARG define

On Tue, Jul 31, 2012 at 7:15 AM, Heiko Carstens
<heiko.carstens@...ibm.com> wrote:
> From: Heiko Carstens <heiko.carstens@...ibm.com>
>
> The LO_ARG define needs to consider endianness also for 32 bit builds.
>
> The "bpf_fancy" test case didn't work on s390 in 32 bit and compat mode
> because the LO_ARG define resulted in a BPF program which read the upper
> halve of the 64 bit system call arguments instead of the lower halves.
>
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>

Good catch; thanks for the fix!

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/