linux-kernel - Re: [PATCH 15/15] workqueue: deprecate __cancel_delayed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120731171146.GA21292@google.com>
Date:	Tue, 31 Jul 2012 10:11:46 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Tomi Valkeinen <tomi.valkeinen@...com>
Cc:	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, padovan@...fusion.mobi,
	marcel@...tmann.org, peterz@...radead.org, mingo@...hat.com,
	davem@...emloft.net, dougthompson@...ssion.com,
	ibm-acpi@....eng.br, cbou@...l.ru, rui.zhang@...el.com,
	Jens Axboe <axboe@...nel.dk>, Jiri Kosina <jkosina@...e.cz>,
	Roland Dreier <roland@...nel.org>
Subject: Re: [PATCH 15/15] workqueue: deprecate __cancel_delayed_work()

On Tue, Jul 31, 2012 at 04:05:39PM +0300, Tomi Valkeinen wrote:
> > Use cancel_delayed_work() instead of __cancel_delayed_work() and mark
> > the latter deprecated.
> 
> I used __cancel_delayed_work() in drivers/video/omap2/dss/dsi.c as the
> cancel is done in an interrupt handler. Is it safe to use
> cancel_delayed_work() in atomic context? I presume not, as it uses
> del_timer_sync().

Ah, you're right.  __cancel_delayed_work() invoked from irq context
can't be converted to cancel_delayed_work() or mod_delayed_work().
I'll skip those from the previous patch and drop this patch.  I really
hope this could be solved somehow tho.  :(

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/