linux-kernel - drivers/misc/apds990x.c: might_sleep operation in interrupt handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 Jul 2012 21:44:22 +0400
From:	Denis Yefremov <yefremov.denis@...il.com>
To:	Greg Kroah-Hartman <gregkh@...e.de>
Cc:	Axel Lin <axel.lin@...il.com>, Arnd Bergmann <arnd@...db.de>,
	linux-kernel@...r.kernel.org, ldv-project@...ras.ru
Subject: drivers/misc/apds990x.c: might_sleep operation in interrupt handler

Interrupt handler apds990x_irq in APDS990x sensor driver
invokes mutex_lock  that is might sleep operation.

Found by Linux Driver Verification project (linuxtesting.org)
within my participation in the GSoC 2012 program.


static irqreturn_t apds990x_irq(int irq, void *data)
{
        struct apds990x_chip *chip = data;
        u8 status;

        apds990x_read_byte(chip, APDS990X_STATUS, &status);
        apds990x_ack_int(chip, status);

        mutex_lock(&chip->mutex);
...
}

static int __devinit apds990x_probe(struct i2c_client *client,
                                const struct i2c_device_id *id)
{
...
        err = request_threaded_irq(client->irq, NULL,
                                apds990x_irq,
                                IRQF_TRIGGER_FALLING | IRQF_TRIGGER_LOW |
                                IRQF_ONESHOT,
                                "apds990x", chip);
...
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/