linux-kernel - Re: [PATCH] misc/pch_phub: Enable UART clock setting by module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201207312101.17095.arnd@arndb.de>
Date:	Tue, 31 Jul 2012 21:01:16 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Tomoya MORINAGA <tomoya.rohm@...il.com>
Cc:	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc/pch_phub: Enable UART clock setting by module parameter

On Tuesday 31 July 2012, Tomoya MORINAGA wrote:
> 
> On Wed, Jul 25, 2012 at 10:31 PM, Arnd Bergmann <arnd@...db.de> wrote:
> > What I think should work better here would be to use the clk API,
> > so that the phub driver registers a 'struct clk' using
> > (I assume) clk_register_divider_table().
> > The UART driver would then call clk_get() to find that clk for
> > the uart device and call clk_set_rate when it needs to change
> > that clock in order to set a different baud rate.
> >
> > Does this make sense?
> >
> 
> Thank you for your comments. This sounds good idea.
> However, it seems the latest kernel doesn't have clk_register_divider_table().
> Will the clk_register_divider_table function be applied soon ?

The code was just merged for v3.6, so it will be in all future kernels that
would also see your changes, but not in older kernels in case you want to
backport your patch.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/