linux-kernel - Re: Q: user_enable_single_step() && update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50192FF5.1060208@linutronix.de>
Date:	Wed, 01 Aug 2012 15:32:37 +0200
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Oleg Nesterov <oleg@...hat.com>
CC:	Roland McGrath <roland@...k.frob.com>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
	ananth@...ibm.com, a.p.zijlstra@...llo.nl, mingo@...hat.com,
	srikar@...ux.vnet.ibm.com
Subject: Re: Q: user_enable_single_step() && update_debugctlmsr()

On 08/01/2012 03:01 PM, Oleg Nesterov wrote:
> Lets ignore uprobes which needs the changes anyway. This is
> only used by ptrace and the task is stopped. So, unless I missed
> something obvious, this update_debugctlmsr() is simply unneeded,
> __switch_to/__switch_to_xtra should notice _TIF_BLOCKSTEP and do
> update_debugctlmsr(DEBUGCTLMSR_BTF).

It looks like it unless a processes ptraces itself (which does not make
much sense anyway).

> But, worse, isn't it wrong? Suppose that debugger switches to
> another TIF_SINGLESTEP&&  !TIF_BLOCKSTEP task, in this case
> we "leak" DEBUGCTLMSR_BTF, no?

__switch_to_xtra() should notice the difference in the TIF_BLOCKSTEP
flag and disable it.

> IOW, it seems to me we could safely remove update_debugctlmsr()
> arch/x86/kernel/step.c. However, if we want to re-use this code
> in uprobes, then we probably need to add "if (child == current)".
It looks that way.

>
> Or I am totally confused. Help!
>
> Oleg.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/