linux-kernel - Re: [PATCH] Fix priority of non-BAR ROM data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo7KKgrtL1ti5dYnykTMiKU2Gf-pviMFqBombdqGih98JA@mail.gmail.com>
Date:	Wed, 1 Aug 2012 08:20:15 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	David Woodhouse <dwmw2@...radead.org>, matt.fleming@...el.com,
	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
	x86@...nel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH] Fix priority of non-BAR ROM data

On Sun, Jul 29, 2012 at 3:53 PM, Matthew Garrett <mjg59@...f.ucam.org> wrote:
> On Sun, Jul 29, 2012 at 10:49:42PM +0100, David Woodhouse wrote:
>> +      * Some devices may provide ROMs via a source other than the BAR
>> +      */
>> +     if (pdev->rom && pdev->romlen) {
>> +             *size = pdev->romlen;
>> +             return phys_to_virt(pdev->rom);
>
> Needs casting. My mistake.

Matthew, are you going to fold this into your patch and repost your
series, or is this a logically separate issue?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/