linux-kernel - Re: [PATCH V3 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201208011438.28719.arnd@arndb.de>
Date:	Wed, 1 Aug 2012 14:38:28 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Vinayak Holikatti <vinholikatti@...il.com>
Cc:	James.Bottomley@...senpartnership.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, patches@...aro.org,
	linux-samsung-soc@...r.kernel.org, arnd@...aro.org,
	girish.shivananjappa@...aro.org, saugata.das@...aro.org,
	vishak.g@...sung.com, venkat@...aro.org, k.rajesh@...sung.com,
	dsaxena@...aro.org, ilho215.lee@...sung.com, nala.la@...sung.com,
	sreekumar.c@...sung.com, Santosh Yaraganavi <santoshsy@...il.com>
Subject: Re: [PATCH V3 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code

On Thursday 26 July 2012, Vinayak Holikatti wrote:

> -static void ufshcd_remove(struct pci_dev *pdev)
> +void ufshcd_remove(struct ufs_hba *hba)
>  {
> -	struct ufs_hba *hba = pci_get_drvdata(pdev);
> -
>  	/* disable interrupts */
>  	ufshcd_int_config(hba, UFSHCD_INT_DISABLE);
> -	free_irq(pdev->irq, hba);
>  
>  	ufshcd_hba_stop(hba);
>  	ufshcd_hba_free(hba);
>  
>  	scsi_remove_host(hba->host);
>  	scsi_host_put(hba->host);
> +}
> +EXPORT_SYMBOL(ufshcd_remove);

For driver internal symbols, you should always use "EXPORT_SYMBOL_GPL"
here.

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/