lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120801172557.GE11359@ovro.caltech.edu>
Date:	Wed, 1 Aug 2012 10:25:57 -0700
From:	"Ira W. Snyder" <iws@...o.caltech.edu>
To:	qiang.liu@...escale.com
Cc:	linux-crypto@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org, dan.j.williams@...il.com,
	Vinod Koul <vinod.koul@...el.com>,
	herbert@...dor.hengli.com.au,
	Dan Williams <dan.j.williams@...el.com>, davem@...emloft.net
Subject: Re: [PATCH v5 6/6] fsl-dma: fix a warning of unitialized cookie

On Wed, Aug 01, 2012 at 04:50:27PM +0800, qiang.liu@...escale.com wrote:
> From: Qiang Liu <qiang.liu@...escale.com>
> 
> Fix a warning of unitialized value when compile with -Wuninitialized.
> 

Looks good to me.

Acked-by: Ira W. Snyder <iws@...o.caltech.edu>

> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Vinod Koul <vinod.koul@...el.com>
> Cc: Li Yang <leoli@...escale.com>
> Signed-off-by: Qiang Liu <qiang.liu@...escale.com>
> Reported-by: Kim Phillips <kim.phillips@...escale.com>
> ---
>  drivers/dma/fsldma.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
> index e3814aa..6fc22eb 100644
> --- a/drivers/dma/fsldma.c
> +++ b/drivers/dma/fsldma.c
> @@ -645,7 +645,7 @@ static dma_cookie_t fsl_dma_tx_submit(struct dma_async_tx_descriptor *tx)
>  	struct fsldma_chan *chan = to_fsl_chan(tx->chan);
>  	struct fsl_desc_sw *desc = tx_to_fsl_desc(tx);
>  	struct fsl_desc_sw *child;
> -	dma_cookie_t cookie;
> +	dma_cookie_t cookie = 0;
> 
>  	spin_lock_bh(&chan->desc_lock);
> 
> --
> 1.7.5.1
> 
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@...ts.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ