linux-kernel - Re: [PATCH v2] platform: Add support for automatic device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120801085857.0304cf0a@endymion.delvare>
Date:	Wed, 1 Aug 2012 08:58:57 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] platform: Add support for automatic device IDs

On Tue, 31 Jul 2012 16:50:59 -0700, Greg KH wrote:
> On Fri, Jul 27, 2012 at 10:14:59PM +0200, Jean Delvare wrote:
> > Right now we have support for explicit platform device IDs, as well as
> > ID-less platform devices when a given device type can only have one
> > instance. However there are cases where multiple instances of a device
> > type can exist, and their IDs aren't (and can't be) known in advance
> > and do not matter. In that case we need automatic device IDs to avoid
> > device name collisions.
> > 
> > I am using magic ID value -2 (PLATFORM_DEVID_AUTO) for this, similar
> > to -1 for ID-less devices. The automatically allocated device IDs are
> > global (to avoid an additional per-driver cost.) We keep note that the
> > ID was automatically allocated so that it can be freed later.
> > 
> > Note that we also restore the ID to PLATFORM_DEVID_AUTO on error and
> > device deletion, to avoid avoid unexpected behavior on retry. I don't
> > really expect retries on platform device addition, but better safe
> > than sorry.
> > 
> > Signed-off-by: Jean Delvare <khali@...ux-fr.org>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Looks sane to me, want me to queue it up for 3.7?

Yes, please!

Thanks,
-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/