linux-kernel - Re: [PATCH] bnx2x: fix mem leak when command is unknown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1343806877.834.3.camel@lb-tlvb-dmitry.il.broadcom.com>
Date:	Wed, 1 Aug 2012 10:41:17 +0300
From:	"Dmitry Kravkov" <dmitry@...adcom.com>
To:	"Jesper Juhl" <jj@...osbits.net>
cc:	"Eilon Greenstein" <eilong@...adcom.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bnx2x: fix mem leak when command is unknown

On Tue, 2012-07-31 at 23:39 +0200, Jesper Juhl wrote:
> In bnx2x_mcast_enqueue_cmd() we'll leak the memory allocated to
> 'new_cmd' if we hit the deafault case of the 'switch (cmd)'.
> Add a 'kfree(new_cmd)' to that case to avoid the leak.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
>   note: due to lack of hardware this patch is compile tested only.
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> index 734fd87..62f754b 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> @@ -2485,6 +2485,7 @@ static int bnx2x_mcast_enqueue_cmd(struct bnx2x *bp,
>  		break;
>  
>  	default:
> +		kfree(new_cmd);
>  		BNX2X_ERR("Unknown command: %d\n", cmd);
>  		return -EINVAL;
>  	}
> -- 
> 1.7.11.3
> 
Thanks a lot, Jesper.

Acked-by: Dmitry Kravkov <dmitry@...adcom.com>
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/