linux-kernel - Re: [PATCH RESEND v5] mmc: core: Remove bounce buffer in mmc_send_cxd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANfBPZ_pVuDU+cd_pQr+GxWd2Dsf3zjfnwW547Sm8SkDaJUuFA@mail.gmail.com>
Date:	Thu, 2 Aug 2012 20:18:54 +0530
From:	"S, Venkatraman" <svenkatr@...com>
To:	Kyungsik Lee <kyungsik.lee@....com>
Cc:	Chris Ball <cjb@...top.org>,
	Jaehoon Chung <jh80.chung@...sung.com>,
	raphael.andy.lee@...il.com, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND v5] mmc: core: Remove bounce buffer in mmc_send_cxd_data()

On Thu, Aug 2, 2012 at 12:37 PM, Kyungsik Lee <kyungsik.lee@....com> wrote:
> It is expected that Extended CSD register(the size of this register
> is larger than CID/CSD) will be referenced more frequently as more
> fields have been added to Extended CSD and it seems that it is not
> a good option to double the memory used.
>
> This patch is intended to avoid the use of bounce buffer for reading
> Extended CSD register in mmc_send_cxd_data(). It will provide a better
> performance gain by removing memcpy() overhead for a half KiB and
> a redundant bounce buffer allocated repeatedly at the cost of providing
> DMA-capable buffer from upper caller(but on-stack buffer is allowed
> with no performance gain).
>
> Signed-off-by: Kyungsik Lee <kyungsik.lee@....com>
> Signed-off-by: S, Venkatraman <svenkatr@...com>

I don't think my sign off is warranted. I gave just an illustration.
You can add my
Reviewed-by: Venkatraman S <svenkatr@...com>

Regards,
Venkat.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/