linux-kernel - Re: [PATCH] checkpatch: Add control statement test to SINGLE_STATEMENT_DO_WHILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14936868.DMgLzkV3C3@bentobox>
Date:	Thu, 02 Aug 2012 18:44:57 +0200
From:	Schrober <franzschrober@...oo.de>
To:	Andy Whitcroft <apw@...onical.com>
Cc:	Joe Perches <joe@...ches.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] checkpatch: Add control statement test to SINGLE_STATEMENT_DO_WHILE_MACRO

On Thursday 02 August 2012 17:23:22 Andy Whitcroft wrote:
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 913d6bd..ca05ba2 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -3016,7 +3016,8 @@ sub process {
> > 
> >  					$herectx .= raw_line($linenr, $n) . "\n";
> >  				
> >  				}
> > 
> > -				if (($stmts =~ tr/;/;/) == 1) {
> > +				if (($stmts =~ tr/;/;/) == 1 &&
> > +				    $stmts !~ /^\s*(if|while|for|switch)\b/) {
> > 
> >  					WARN("SINGLE_STATEMENT_DO_WHILE_MACRO",
> >  					
> >  					     "Single statement macros should not use a do {} while 
(0)
> >  					     loop\n" . "$herectx");>  				
> >  				}
> 
> Looks reasonable enough.
> 
> Acked-by: Andy Whitcroft <apw@...onical.com>

Works well for me, thanks

Just as note: I think this test was accidently added twice. Once in commit 
b13edf7ff2dd0fef95e981170fa71fa6b60421b0 and one time in 
7d64ef43914a734990e48a80bc60686c8db21946 (just checked linux-next, and Stephen 
added it again). Maybe Andrew Morton's tree is out of sync.
-- 
Franz Schrober
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/