linux-kernel - Re: [PATCH] apple-gmux: Fix kconfig dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <501AE0C9.1060402@xenotime.net>
Date:	Thu, 02 Aug 2012 13:19:21 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Seth Forshee <seth.forshee@...onical.com>
CC:	Matthew Garrett <mjg@...hat.com>,
	platform-driver-x86@...r.kernel.org,
	Arun Raghavan <arun.raghavan@...labora.co.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] apple-gmux: Fix kconfig dependencies

On 08/02/2012 10:15 AM, Seth Forshee wrote:

> Fix the dependencies of apple-gmux to prevent it from being built-in
> when one or more of its dependencies is built as a module. Otherwise it
> can fail to build due to missing symbols.
> 
> v2: Add dependency on ACPI to fix build failure when ACPI=n
> 
> Reported-by: Arun Raghavan <arun.raghavan@...labora.co.uk>
> Signed-off-by: Seth Forshee <seth.forshee@...onical.com>


Acked-by: Randy Dunlap <rdunlap@...otime.net>

Thanks.

> ---
>  drivers/platform/x86/Kconfig |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 2a262f5..637074d 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -758,8 +758,11 @@ config SAMSUNG_Q10
>  
>  config APPLE_GMUX
>  	tristate "Apple Gmux Driver"
> +	depends on ACPI
>  	depends on PNP
> -	select BACKLIGHT_CLASS_DEVICE
> +	depends on BACKLIGHT_CLASS_DEVICE
> +	depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
> +	depends on ACPI_VIDEO=n || ACPI_VIDEO
>  	---help---
>  	  This driver provides support for the gmux device found on many
>  	  Apple laptops, which controls the display mux for the hybrid



-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/