linux-kernel - [PATCH] [ipc/shm] make shmget with IPC_PRIVATE initially created with SHM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1343995990-1358-1-git-send-email-microcai@fedoraproject.org>
Date:	Fri,  3 Aug 2012 20:13:10 +0800
From:	microcai <microcai@...oraproject.org>
To:	linux-kernel@...r.kernel.org
Cc:	kernel@...r.linux-kernel.cn, microcai <microcai@...oraproject.org>
Subject: [PATCH] [ipc/shm] make shmget with IPC_PRIVATE initially created with SHM_DEST

The problem is SysV SHM is that , it will cause kernel resource leak.
Initailly set shm  mode to SHM_DEST when create with key_t IPC_PRIVATE,
then the resource leak is fixed.

If program want the shmid live longer, they will probably use non
IPC_PRIVATE nor call shmctl that remove SHM_DEST bit.
---
 ipc/shm.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/ipc/shm.c b/ipc/shm.c
index 41c1285..1abc031 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -480,6 +480,8 @@ static int newseg(struct ipc_namespace *ns, struct ipc_params *params)
 
 	shp->shm_perm.key = key;
 	shp->shm_perm.mode = (shmflg & S_IRWXUGO);
+	if(key == IPC_PRIVATE)
+		shp->shm_perm.mode |= SHM_DEST;
 	shp->mlock_user = NULL;
 
 	shp->shm_perm.security = NULL;
-- 
1.7.8.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/