linux-kernel - Re: [PATCH] thinkpad-acpi: recognize latest V-Series using DMI_BIOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1208030005470.3041@lazy>
Date:	Fri, 3 Aug 2012 00:07:06 -0500 (CDT)
From:	Manoj Iyer <manoj.iyer@...onical.com>
To:	manoj.iyer@...onical.com
cc:	linux-kernel@...r.kernel.org, ibm-acpi-devel@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, mjg@...hat.com,
	ibm-acpi@....eng.br
Subject: Re: [PATCH] thinkpad-acpi: recognize latest V-Series using
 DMI_BIOS_VENDOR


Oops! This is embarrassing! my logic is flawed. Please ignore this patch, 
I will resend it

NACK


On Thu, 2 Aug 2012, manoj.iyer@...onical.com wrote:

> From: Manoj Iyer <manoj.iyer@...onical.com>
>
> In the latest V-series bios DMI_PRODUCT_VERSION does not contain
> the string Lenovo or Thinkpad, but is set to the model number, this
> causes the thinkpad_acpi module to fail to load. Recognize laptop
> as Lenovo using DMI_BIOS_VENDOR instead, which is set to Lenovo.
>
> Signed-off-by: Manoj Iyer <manoj.iyer@...onical.com>
> ---
> drivers/platform/x86/thinkpad_acpi.c |    3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index e7f7328..eec0b65 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -8657,7 +8657,8 @@ static int __must_check __init get_thinkpad_model_data(
> 		}
> 	}
>
> -	s = dmi_get_system_info(DMI_PRODUCT_VERSION);
> +	s = dmi_get_system_info(DMI_PRODUCT_VERSION) ?
> +		dmi_get_system_info(DMI_BIOS_VENDOR) : NULL;
> 	if (s && !(strnicmp(s, "ThinkPad", 8) && strnicmp(s, "Lenovo", 6))) {
> 		tp->model_str = kstrdup(s, GFP_KERNEL);
> 		if (!tp->model_str)
> -- 
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>

--
====================
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement
====================
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/