linux-kernel - Re: oops in pci_acs_path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <501C4BCA.1080804@gmail.com>
Date:	Fri, 03 Aug 2012 16:08:10 -0600
From:	David Ahern <dsahern@...il.com>
To:	Alex Williamson <alex.williamson@...hat.com>
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: oops in pci_acs_path_enabled

On 8/3/12 3:52 PM, Alex Williamson wrote:
> Is this the chunk that's causing the oops?

Yes. And taking it out fixes passthrough as well.

David


>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 7469b53..27d8c97 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -4133,6 +4133,7 @@ static int intel_iommu_add_device(struct device *dev)
>                                            PCI_DEVFN(PCI_SLOT(dma_pdev->devfn),
>                                            0)));
>
> +#if 0
>          while (!pci_is_root_bus(dma_pdev->bus)) {
>                  if (pci_acs_path_enabled(dma_pdev->bus->self,
>                                           NULL, REQ_ACS_FLAGS))
> @@ -4140,6 +4141,7 @@ static int intel_iommu_add_device(struct device *dev)
>
>                  swap_pci_ref(&dma_pdev, pci_dev_get(dma_pdev->bus->self));
>          }
> +#endif
>
>          group = iommu_group_get(&dma_pdev->dev);
>          pci_dev_put(dma_pdev);
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/