linux-kernel - Re: [PATCH] regmap-irq: allow auto-allocated IRQs to be mapped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120804105424.GB10523@opensource.wolfsonmicro.com>
Date:	Sat, 4 Aug 2012 11:54:24 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Anthony Olech <anthony.olech.opensource@...semi.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Anthony Olech <anthony.olech@...semi.com>,
	Dajun Chen <david.chen@...semi.com>
Subject: Re: [PATCH] regmap-irq: allow auto-allocated IRQs to be mapped

On Wed, Aug 01, 2012 at 07:05:15PM +0100, Anthony Olech wrote:

> if the irq_base is set to -1 when calling regmap_add_irq_chip()
> then allow the IRQ to be mapped even if the allocated irq_base
> is actually zero.

> This restores the behaviour seen in v3.4, and I assume that the
> tidy-ups just made in v3.5 INADVERTENTLY introduce this change
> in behaviour.

Please pay MORE attention to the changelog - obviously there's no
problem mapping automatically allocated IRQs, there's only any effect if
they happen to GET allocated at zero.

The only real issue I see with the current code is that if the user
explicitly wants to statically allocate an IRQ range at zero they can't.
The current intended behaviour is that we use a linear domain unless a
positive IRQ base is specified, though we're not quite doing that right
now as a transitional measure until drivers are updated.

The current da9052 driver usage seems to have quite a few problems, I do
recall having to fix some problems that make me doubt if it ever worked
well.  Looking at the code now I see it's using hard coded references to
absolute IRQ numbers which is an issue...  It should be being converted
to use regmap_irq_get_virq().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/