linux-kernel - [PATCH] staging: sm7xxfb: copy name of the device before calling smtc_alloc_fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1344100872-19640-1-git-send-email-develkernel412222@gmail.com>
Date:	Sat,  4 Aug 2012 23:06:12 +0545
From:	Devendra Naga <develkernel412222@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Javier Muñoz <jmunhoz@...lia.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Devendra Naga <devendra.aaru@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Cc:	Devendra Naga <develkernel412222@...il.com>
Subject: [PATCH] staging: sm7xxfb: copy name of the device before calling smtc_alloc_fb_info

as we do a strcpy(smdrv_ptr->fb_struct->fix->id, name), and the name here in
sm7xxx_probe is not having any assignment, and which leads to copying of the garbage value
into the id field of the fix struct of fb interface struct. fix it by copying the name before
calling alloc_fbinfo

Signed-off-by: Devendra Naga <develkernel412222@...il.com>
---
 Only compile tested
 This patch is not tested using the hardware... if any one is having this hardware, i request them to
please test this
 drivers/staging/sm7xxfb/sm7xxfb.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
index 1c1780c..d3957ef 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -798,16 +798,17 @@ static int __devinit smtcfb_pci_probe(struct pci_dev *pdev,
 	if (err)
 		return err;
 
+	sprintf(name, "sm%Xfb", ent->device);
+
 	sfb = smtc_alloc_fb_info(pdev, name);
 
+	sfb->chip_id = ent->device;
+
 	if (!sfb) {
 		err = -ENOMEM;
 		goto failed_free;
 	}
 
-	sfb->chip_id = ent->device;
-	sprintf(name, "sm%Xfb", sfb->chip_id);
-
 	pci_set_drvdata(pdev, sfb);
 
 	sm7xx_init_hw();
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/